RFR: 8297953: Fix several C2 IR matching tests for RISC-V
Feilong Jiang
fjiang at openjdk.org
Fri Dec 2 11:28:06 UTC 2022
On Thu, 1 Dec 2022 14:05:52 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Fix several IR matching tests that failed on RISC-V.
>>
>> Rotate Node will be matched only when UseZbb is enabled:
>> - test/hotspot/jtreg/compiler/c2/irTests/RotateLeftNodeIntIdealizationTests.java
>> - test/hotspot/jtreg/compiler/c2/irTests/RotateLeftNodeLongIdealizationTests.java
>>
>> RISC-V does not provide float branch instruction, so we do not match CMOVEI for two floating-point comparisons:
>> - test/hotspot/jtreg/compiler/c2/irTests/TestFPComparison.java
>>
>> Testing:
>> - test/hotspot/jtreg/compiler/c2/irTests/TestFPComparison.java -- no tests selected as expected.
>>
>> - With `-XX:+UseZbb`:
>> - test/hotspot/jtreg/compiler/c2/irTests/RotateLeftNodeIntIdealizationTests.java -- passed
>> - test/hotspot/jtreg/compiler/c2/irTests/RotateLeftNodeLongIdealizationTests.java -- passed
>>
>> - With `-XX:-UseZbb`:
>> - test/hotspot/jtreg/compiler/c2/irTests/RotateLeftNodeIntIdealizationTests.java -- no tests selected as expected
>> - test/hotspot/jtreg/compiler/c2/irTests/RotateLeftNodeLongIdealizationTests.java -- no tests selected as expected
>
> Looks reasonable to me. Thanks.
@RealFYang @chhagedorn -- Thanks for looking at this.
-------------
PR: https://git.openjdk.org/jdk/pull/11453
More information about the hotspot-compiler-dev
mailing list