RFR: 8298088: RISC-V: Make Address a discriminated union internally

Feilong Jiang fjiang at openjdk.org
Mon Dec 5 13:43:48 UTC 2022


On Mon, 5 Dec 2022 08:42:22 GMT, Fei Yang <fyang at openjdk.org> wrote:

> The RISC-V port has the same issue as: https://bugs.openjdk.org/browse/JDK-8297830
> It looks to me that the fix for the AArch64 port is a nice refactoring work.
> This fixes this issue for the RISC-V port with a similar approach.
> 
> Testing:
>   Tier1 tested with release build on linux-riscv64 unmatched board.
>   Run non-trivial benchmark workloads with fastdebug builds.

Nice cleanup! With one comment:

src/hotspot/cpu/riscv/assembler_riscv.hpp line 33:

> 31: #include "assembler_riscv.inline.hpp"
> 32: #include "metaprogramming/enableIf.hpp"
> 33: 

I think this blank line can be removed.

-------------

Marked as reviewed by fjiang (Author).

PR: https://git.openjdk.org/jdk/pull/11505


More information about the hotspot-compiler-dev mailing list