RFR: 8297036: Generalize C2 stub mechanism [v11]

Vladimir Kozlov kvn at openjdk.org
Tue Dec 6 18:16:22 UTC 2022


On Tue, 6 Dec 2022 17:44:54 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Currently, we have two implementations of out-of-line stubs in C2, one for safepoint poll stubs (C2SafepointPollStubTable in output.hpp) and another for nmmethod entry barriers (C2EntryBarrierStubTable in output.hpp). I will need a few more for Lilliput: One for checking lock-stack size in method prologue, one for handling lock failures (both for fast-locking), and another one for load-klass slow-path. It would be good to generalize the mechanism and consolidate the existing uses on the new general mechanism.
>> 
>> Testing:
>>  - [x] tier1 (x86_64, x86_32, aarch64)
>>  - [x] tier2 (x86_64, x86_32, aarch64)
>>  - [x] tier3 (x86_64, x86_32, aarch64)
>
> Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 32 additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into JDK-8297036
>  - PPC fixes
>  - Update copyright notices
>  - More renames. Duh
>  - Rename C2CodeStub::size() -> max_size()
>  - Relax size-check in C2CodeStubList::emit()
>  - More RISCV fixes
>  - PPC fix
>  - x86_32 fix
>  - AArch64 parts
>  - ... and 22 more: https://git.openjdk.org/jdk/compare/18233c9c...b28f45d5

This looks good now. Let me run it through our testing.

-------------

PR: https://git.openjdk.org/jdk/pull/11188


More information about the hotspot-compiler-dev mailing list