RFR: 8298345: Fix another two C2 IR matching tests for RISC-V
Feilong Jiang
fjiang at openjdk.org
Thu Dec 8 06:28:55 UTC 2022
On Thu, 8 Dec 2022 03:26:38 GMT, Gui Cao <gcao at openjdk.org> wrote:
> Fix two IR matching tests that failed on RISC-V.
>
> Vector api Node will be matched only when UseRVV is enabled:
> - test/hotspot/jtreg/compiler/c2/irTests/TestAutoVectorization2DArray.java
> - test/hotspot/jtreg/compiler/vectorization/TestAutoVecIntMinMax.java
>
> Please take a look and have some reviews. Thanks a lot.
>
> ## Testing:
> - fastdebug on unmatched board without support for RVV
> - - test/hotspot/jtreg/compiler/c2/irTests/TestAutoVectorization2DArray.java - no tests selected as expected
> - - test/hotspot/jtreg/compiler/vectorization/TestAutoVecIntMinMax.java - no tests selected as expected
> - fastdebug with -XX:+UseRVV on QEMU
> - - test/hotspot/jtreg/compiler/c2/irTests/TestAutoVectorization2DArray.java - The C2 graph generated by the test is as expected
> - - test/hotspot/jtreg/compiler/vectorization/TestAutoVecIntMinMax.java -The C2 graph generated by the test is as expected
> - fastdebug with -XX:-UseRVV on QEMU
> - - test/hotspot/jtreg/compiler/c2/irTests/TestAutoVectorization2DArray.java - no tests selected as expected
> - - test/hotspot/jtreg/compiler/vectorization/TestAutoVecIntMinMax.java - no tests selected as expected
Thanks for the fixing, with one comment:
test/hotspot/jtreg/compiler/c2/irTests/TestAutoVectorization2DArray.java line 32:
> 30: * @bug 8279258
> 31: * @summary Auto-vectorization enhancement for two-dimensional array operations
> 32: * @requires ((os.arch == "x86" | os.arch == "i386") & (vm.opt.UseSSE == "null" | vm.opt.UseSSE >= 2))
Did you check that still works on other arches? e.g.: x64/aarch64
-------------
PR: https://git.openjdk.org/jdk/pull/11577
More information about the hotspot-compiler-dev
mailing list