RFR: 8160404: RelocationHolder constructors have bugs [v2]

Kim Barrett kbarrett at openjdk.org
Mon Dec 12 17:56:12 UTC 2022


On Mon, 12 Dec 2022 11:46:33 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   blank lines in include blocks
>
> src/hotspot/share/code/relocInfo.cpp line 39:
> 
>> 37: #include "utilities/copy.hpp"
>> 38: #include <new>
>> 39: #include <type_traits>
> 
> Please add an empty blank line between HotSpot includes and system includes. We don't explicitly state this, but this was the style that we generated when IncludeDB was removed.

Done.

> src/hotspot/share/code/relocInfo.hpp line 33:
> 
>> 31: #include "utilities/globalDefinitions.hpp"
>> 32: #include "utilities/macros.hpp"
>> 33: #include <new>
> 
> Add blank line

Done.

-------------

PR: https://git.openjdk.org/jdk/pull/11618


More information about the hotspot-compiler-dev mailing list