RFR: 8297933: [REDO] Compiler should only use verified interface types for optimization [v2]

Roland Westrelin roland at openjdk.org
Wed Dec 14 15:44:57 UTC 2022


On Wed, 14 Dec 2022 14:15:04 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   test fix
>
> test/hotspot/jtreg/compiler/types/TestCheckCastPPBecomesTOP.java line 28:
> 
>> 26:  * @bug 8297345
>> 27:  * @summary C2: SIGSEGV in PhaseIdealLoop::push_pinned_nodes_thru_region
>> 28:  * @requires vm.gc.Parallel
> 
> I think it should be:
> 
> Suggestion:
> 
>  * @requires vm.gc == null | vm.gc.Parallel

FTR, I discussed this privately with Tobias. His concern is that the test would not be run if not passed `-XX:+UseParallelGC`. That doesn't seem to be an issue though as the test runs as expected when passed no option or `-XX:+UseParallelGC` and doesn't run with a command line option that enables some other gc.

-------------

PR: https://git.openjdk.org/jdk/pull/11666


More information about the hotspot-compiler-dev mailing list