RFR: 8297582: C2: very slow compilation due to type system verification code [v2]

[Roland Westrelin]

On Thu, 15 Dec 2022 01:28:27 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   build fix
>
> src/hotspot/share/opto/type.cpp line 918:
> 
>> 916:   TypeVerif verif(C);
>> 917: #endif
>> 918: 
> 
> Can `VerifyMeetResult` class be local to `Type` class instead of `Compile` since it is used only locally here and you reset cache each time anyway? (`Compile` is become very big with verification code from all parts of compiler).
> 
> I thought you build the cache for duration of compilation then it may make sense to keep it in `Compile`. But you are resetting it after each `meet` so you don't need to have it in `Compile`.

What I could do is have a pointer to the cache as a field in Compile but move the new class declaration out of compile.hpp in type.[ch]pp? Does that sound ok to you?

-------------

PR: https://git.openjdk.org/jdk/pull/11673