RFR: 8297933: [REDO] Compiler should only use verified interface types for optimization [v2]

Roland Westrelin roland at openjdk.org
Thu Dec 15 11:15:52 UTC 2022


On Thu, 15 Dec 2022 00:52:03 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   test fix
>
> src/hotspot/share/ci/ciInstanceKlass.cpp line 745:
> 
>> 743:           Array<InstanceKlass*>* interfaces = ik->transitive_interfaces();
>> 744:           Arena* arena = CURRENT_ENV->arena();
>> 745:           int len = interfaces->length() + (is_interface() ? 1 : 0);
> 
> I think you need to cache `interfaces->length()` in local variable to use in following loop to make sure it is the same value. I concern that an other thread may change it.

Done in new commit.

-------------

PR: https://git.openjdk.org/jdk/pull/11666


More information about the hotspot-compiler-dev mailing list