RFR: 8297582: C2: very slow compilation due to type system verification code [v3]

[Vladimir Kozlov]

On Thu, 15 Dec 2022 19:48:37 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Vladimir's review
>
> src/hotspot/share/opto/type.cpp line 989:
> 
>> 987:   const Type *mt = this_t->xmeet(t);
>> 988: #ifdef ASSERT
>> 989:   VerifyMeetResult* type_verify = C->_type_verify;
> 
> As a style nit, you could access `VerifyMeetResult*` through `VerifyMeetMark` or even encapsulate it there.

I assume you suggested to hide access  to cache (`add()`, `meet()`) in `VerifyMeetMark`. I agree. `VerifyMeetMark` can be renamed `VerifyMeet` in such case.

-------------

PR: https://git.openjdk.org/jdk/pull/11673