RFR: 8298088: RISC-V: Make Address a discriminated union internally [v2]

Fei Yang fyang at openjdk.org
Fri Dec 16 01:02:09 UTC 2022


On Mon, 5 Dec 2022 13:57:12 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> The RISC-V port has the same issue as: https://bugs.openjdk.org/browse/JDK-8297830
>> It looks to me that the fix for the AArch64 port is a nice refactoring work.
>> This fixes this issue for the RISC-V port with a similar approach.
>> 
>> Testing:
>>   Tier1 tested with release build on linux-riscv64 unmatched board.
>>   Run non-trivial benchmark workloads with fastdebug builds.
>
> Fei Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review

> AArch64 patch ([5a5ced3](https://github.com/openjdk/jdk/commit/5a5ced3a900a81fd0b0757017f4138ce97e2521e)) also has modifications that rewrite `_offset` -> `offset()`, `_base` -> `base()`, `_index` -> `index()`, etc. Does RISC-V code has the relevant uses too?

Hi, I double-checked files assembler_riscv.hpp/cpp and macroAssembler_riscv.hpp/cpp. And I don't see any occurrence of direct uses for those private data members.

-------------

PR: https://git.openjdk.org/jdk/pull/11505


More information about the hotspot-compiler-dev mailing list