RFR: 8160404: RelocationHolder constructors have bugs [v2]

Kim Barrett kbarrett at openjdk.org
Fri Dec 16 04:48:45 UTC 2022


On Thu, 15 Dec 2022 21:34:02 GMT, John R Rose <jrose at openjdk.org> wrote:

> I suggest putting all the static asserts in one place, instead of two of them in place A and the third (trivial destructor) in place B.

The static asserts about class relationships and size are checked where they are relied upon.  The trivial destructor assumption is relied upon elsewhere (holder assignment, copy_into implementations, and ~Relocation) and not there.  There isn't really a single good place to verify assumption.  I've expanded on comments to indicate where that assumption comes into play.

-------------

PR: https://git.openjdk.org/jdk/pull/11618


More information about the hotspot-compiler-dev mailing list