RFR: JDK-8153837: AArch64: Handle special cases for MaxINode & MinINode [v2]

Dmitry Chuyko dchuyko at openjdk.org
Sat Dec 17 02:18:04 UTC 2022


On Fri, 16 Dec 2022 02:37:22 GMT, Hao Sun <haosun at openjdk.org> wrote:

>> Dmitry Chuyko has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reverted Ideal change, moved definitions to m4
>
> src/hotspot/cpu/aarch64/aarch64_ad.m4 line 555:
> 
>> 553: 
>> 554:   ins_encode %{
>> 555:     __ $2(as_Register($dst$$reg),
> 
> I wonder if it would be better to use `$dst$$Register` here and several other sites in this patch.
> Suggestion:
> 
>     __ $2($dst$$Register,

Changed as suggested. I also made some cleanup in .m4 to and fixed minor .ad-.m4 mismatches.

-------------

PR: https://git.openjdk.org/jdk/pull/11570


More information about the hotspot-compiler-dev mailing list