RFR: 8298736: Revisit usages of log10 in compiler code

Damon Fenacci duke at openjdk.org
Mon Dec 19 08:42:48 UTC 2022


On Thu, 15 Dec 2022 13:14:57 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> The use of the Math library `log10` function causes an overloading ambiguity error on SPARC when using it with integer typed parameters.
>> 
>> * adding a `static_cast<double>` to the parameter
>> * using the lib `log10` function (with `static_cast`s) instead of a custom one in `src/hotspot/share/opto/node.cpp`
>
> Looks good to me too.

@TobiHartmann @chhagedorn @eme64 thanks for your reviews!

-------------

PR: https://git.openjdk.org/jdk/pull/11686


More information about the hotspot-compiler-dev mailing list