RFR: 8298913: Add override qualifiers to Relocation classes

Kim Barrett kbarrett at openjdk.org
Mon Dec 19 09:06:44 UTC 2022


Please review this change to the Relocation classes, adding `override`
qualifiers to all overriding virtual function declarations.

Testing:
mach5 tier1

Note that building with clang (on macosx) subjected these changes to clang's
`-Winconsistent-missing-override` option.

Note that there are a lot of member functions missing `const` qualifiers in
the Relocation hierarchy.  I may look at improving const-correctness later.
After doing a little exploration down that path, it looks like it might be a
bit messy.

-------------

Commit messages:
 - add override qualifiers

Changes: https://git.openjdk.org/jdk/pull/11716/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11716&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8298913
  Stats: 58 lines in 1 file changed: 0 ins; 0 del; 58 mod
  Patch: https://git.openjdk.org/jdk/pull/11716.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11716/head:pull/11716

PR: https://git.openjdk.org/jdk/pull/11716


More information about the hotspot-compiler-dev mailing list