RFR: 8298913: Add override qualifiers to Relocation classes

Axel Boldt-Christmas aboldtch at openjdk.org
Tue Dec 20 08:52:48 UTC 2022


On Mon, 19 Dec 2022 08:58:24 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to the Relocation classes, adding `override`
> qualifiers to all overriding virtual function declarations.
> 
> Testing:
> mach5 tier1
> 
> Note that building with clang (on macosx) subjected these changes to clang's
> `-Winconsistent-missing-override` option.
> 
> Note that there are a lot of member functions missing `const` qualifiers in
> the Relocation hierarchy.  I may look at improving const-correctness later.
> After doing a little exploration down that path, it looks like it might be a
> bit messy.

lgtm.

-------------

Marked as reviewed by aboldtch (Committer).

PR: https://git.openjdk.org/jdk/pull/11716


More information about the hotspot-compiler-dev mailing list