RFR: 8299061: Using lambda to optimize GraphKit::compute_stack_effects() [v2]
Xin Liu
xliu at openjdk.org
Tue Dec 20 23:33:51 UTC 2022
On Tue, 20 Dec 2022 09:35:17 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> further simplify the lambda based on the feedbacks of reviewers.
>
> src/hotspot/share/opto/graphKit.cpp line 1032:
>
>> 1030: rtype = Bytecodes::result_type(code); // checkcast=P, athrow=V
>> 1031: if (rtype < T_CONFLICT)
>> 1032: sz = type2size[rtype];
>
> [pre-existing] Missing braces around the consequent. Maybe write this instead as
>
> if (rtype < T_CONFLICT) {
> return type2size[rtype];
> } else {
> return 0;
> }
>
> avoiding the introduction of the `sz` variable.
make sense. I should be an expression.
-------------
PR: https://git.openjdk.org/jdk/pull/11737
More information about the hotspot-compiler-dev
mailing list