RFR: 8299191: Unnecessarily global friend functions for relocInfo [v2]

[Kim Barrett]

> Please review this small cleanup around the relocInfo class.  It declares a
> couple of global functions as friends, so they have access to private
> constructors and helper functions.  But there is no reason for these functions
> to be at global scope.  It is more natural for them to be static factory
> functions in relocInfo.
> 
> Testing:
> mach5 tier1

Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into relocinfo-friends
 - make friend functions instead be static members

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11753/files
  - new: https://git.openjdk.org/jdk/pull/11753/files/90893679..86f991f3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11753&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11753&range=00-01

  Stats: 4233 lines in 239 files changed: 2810 ins; 757 del; 666 mod
  Patch: https://git.openjdk.org/jdk/pull/11753.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11753/head:pull/11753

PR: https://git.openjdk.org/jdk/pull/11753