RFR: 8279219: [REDO] C2 crash when allocating array of size too large [v2]

[Roland Westrelin]

On Thu, 27 Jan 2022 17:22:13 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/opto/macro.cpp line 1397:
> 
>> 1395:   // allocate node with the call
>> 1396:   call->copy_call_debug_info(&_igvn, alloc);
>> 1397:   if (valid_length_test != NULL) {
> 
> How about adding a comment or assert that makes it clear that valid_length_test != NULL if it's an array that's allocated? If length == NULL, then valid_length_test is NULL too. Just to ease the reading of this code a bit.

Thanks for looking at this.
What about the comment I just pushed?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6952