RFR: 8278947: Support for array constants in constant table [v2]

[Vladimir Ivanov]

On Tue, 4 Jan 2022 08:47:52 GMT, Quan Anh Mai <duke at openjdk.java.net> wrote:

>> Hi,
>> 
>> This patch adds support for arrays in compiled code constant tables and uses it for various vector replicate operations on x86.
>> 
>> Test: GHA, linux x64 tier 1-3
>> 
>> Thank you very much.
>
> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - Merge branch 'master' into constantVectorUpdate
>  - update copyright
>  - missing type in array_constant
>  - Merge branch 'master' into constantVector
>  - use constant table for remaining types
>  - Merge branch 'master' into constantVector
>  - refactor
>  - replicate using constant
>  - Merge branch 'master' into constantVector
>  - initial commit

Nice improvement!

src/hotspot/share/opto/constantTable.hpp line 41:

> 39:   private:
> 40:     BasicType _type;
> 41:     bool _is_array;

Can you rely on `_type` and just use `T_ARRAY` tag for that purpose?

-------------

Marked as reviewed by vlivanov (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6908