RFR: 8281732: add assert for non-NULL assumption for return of unique_ctrl_out [v2]
Emanuel Peter
duke at openjdk.java.net
Mon Feb 14 15:18:52 UTC 2022
> unique_ctrl_out was used in contexts where NULL may be a valid return, and is also used in contexts where NULL is not expected.
>
> I improved the code by having two functions instead:
> unique_ctrl_out_or_null: return the unique control out, or NULL if there is no or more than one control out.
> unique_ctrl_out: return the unique control out, assert if there is no or more than one control out.
>
> This makes implicit assumptions explicit and also validates them in the future.
>
> I changed the usage to unique_ctrl_out_or_null where NULL is among the expected return values.
Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
fix copyright year and minor code style issues
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7462/files
- new: https://git.openjdk.java.net/jdk/pull/7462/files/a23b34ad..d2efb501
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7462&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7462&range=00-01
Stats: 8 lines in 6 files changed: 0 ins; 0 del; 8 mod
Patch: https://git.openjdk.java.net/jdk/pull/7462.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/7462/head:pull/7462
PR: https://git.openjdk.java.net/jdk/pull/7462
More information about the hotspot-compiler-dev
mailing list