RFR: 8267265: Use new IR Test Framework to create tests for C2 Ideal transformations [v2]

Christian Hagedorn chagedorn at openjdk.java.net
Tue Feb 15 08:42:10 UTC 2022


On Mon, 14 Feb 2022 07:53:19 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Cesar Soares has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing typos & compilation
>
> test/hotspot/jtreg/compiler/c2/irTests/DivINodeIdealizationTests.java line 149:
> 
>> 147:                  })
>> 148:     // Checks (x & -(2^c0)) / 2^c1 => (x >> c1) & (2^c0 >> c1) => (x >> c1) & c3 where 2^c0 > |2^c1| and c3 = 2^c0 >> c1
>> 149:     // Having a large enough and in the dividend removes the need to account for rounding when converting to shifts and multiplies as in divByPow2()
> 
> Maybe you capitalize `and` -> `AND`, same further down. I first read it as a normal word "and" which was confusing :-)

I've actually meant the comments themselves but it's just a minor thing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7434


More information about the hotspot-compiler-dev mailing list