RFR: 8282025: assert(ctrl != __null) failed: control out is assumed to be unique after JDK-8281732

[Tobias Hartmann]

On Wed, 16 Feb 2022 23:08:18 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Hi all,
> 
> The following tests fail after JDK-8281732.
> 
> compiler/gcbarriers/UnsafeIntrinsicsTest.java
> gc/metaspace/TestMetaspacePerfCounters.java
> gc/shenandoah/TestEvilSyncBug.java
> gc/stringdedup/TestStringDeduplicationFullGC.java
> gc/stringdedup/TestStringDeduplicationTableResize.java
> gc/stringdedup/TestStringDeduplicationYoungGC.java
> serviceability/dcmd/gc/HeapDumpCompressedTest.java
> jdk/jfr/event/gc/detailed/TestGCPhaseConcurrent.java
> jdk/jfr/event/gc/detailed/TestShenandoahHeapRegionStateChangeEvent.java
> jdk/jfr/event/gc/detailed/TestShenandoahHeapRegionInformationEvent.java
> jdk/jfr/event/oldobject/TestShenandoah.java
> sun/net/www/protocol/https/HttpsURLConnection/B6216082.java
> sun/tools/jmap/BasicJMapTest.java
> ``` 
> 
> The fix just replaces `unique_ctrl_out()` with `unique_ctrl_out_or_null()`.
> 
> Testing:
>  - All failing tests passed after this patch
> 
> Thanks.
> Best regards,
> Jie

Looks good.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7508