RFR: 8005885: enhance PrintCodeCache to print more data
Xin Liu
xliu at openjdk.java.net
Thu Feb 17 18:38:12 UTC 2022
On Tue, 8 Feb 2022 19:17:32 GMT, Yi-Fan Tsai <duke at openjdk.java.net> wrote:
> 8005885: enhance PrintCodeCache to print more data
My comments are nits. Generally, this PR looks good to me.
I am not a reviewer. We still need other reviewers to approve it.
src/hotspot/share/code/codeCache.cpp line 109:
> 107: void print(const char* title) const {
> 108: if (is_empty())
> 109: {
better stick with the existing codestyle. they always use if (cond) { and else {
src/hotspot/share/code/codeCache.cpp line 1497:
> 1495: };
> 1496: tty->print_cr("Stubs:");
> 1497: for (auto &stub: stubs) {
current code style prefer auto& stub. same as 1486 1487 lines, asterisk associates with type.
-------------
Marked as reviewed by xliu (Committer).
PR: https://git.openjdk.java.net/jdk/pull/7389
More information about the hotspot-compiler-dev
mailing list