RFR: 8281936: compiler/arguments/TestCodeEntryAlignment.java fails on AVX512 machines [v2]

Vladimir Kozlov kvn at openjdk.java.net
Thu Feb 17 19:49:10 UTC 2022


On Thu, 17 Feb 2022 08:16:38 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Hi all, 
>> 
>> compiler/arguments/TestCodeEntryAlignment.java fails on AVX512 machines due to stub size is not big enough.
>> The fix just increasing the stub size for AVX512 platforms.
>> 
>> Testing:
>>   - tier1~3 on Linux/x64 with AVX512, no regression
>> 
>> Thanks.
>> Best regards,
>> Jie
>
> Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comment

I would like to hear explanation why the test failed with `-XX:CodeEntryAlignment=16` on avx512 when it passed with bigger default value 32 (or other bigger values): 
https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/globals_x86.hpp#L47

It looks like somewhere we use CodeEntryAlignment to calculate some buffer size. It seems we need to fix that place instead of just bumping this CodeBuffer size.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7485


More information about the hotspot-compiler-dev mailing list