RFR: 8281079: [s390] Unify Address Operand Encoding in Instruction Emitters

Lutz Schmidt lucy at openjdk.java.net
Tue Feb 22 07:41:47 UTC 2022


On Mon, 21 Feb 2022 13:59:19 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> May I please request reviews for this cleanup and unification change. It streamlines the address operand emitters for all instructions. As such, the modifications are widespread and may be cumbersome to review. Please ask questions if anything is unclear.
>> 
>> SAP does not maintain a full s390x build and test environment any longer. I would therefore very much appreciate if somebody would run a build and test cycle on s390x. 
>> 
>> As this is a s390x-only change, other platforms are not impacted.
>
> src/hotspot/cpu/s390/assembler_s390.hpp line 1812:
> 
>> 1810:   inline void emit_data(int x);
>> 1811: 
>> 1812: // private:
> 
> Uncommon. Should better get removed.

Agreed. Will get removed with next commit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7324


More information about the hotspot-compiler-dev mailing list