RFR: 8281079: [s390] Unify Address Operand Encoding in Instruction Emitters

Martin Doerr mdoerr at openjdk.java.net
Tue Feb 22 08:47:49 UTC 2022


On Tue, 22 Feb 2022 08:42:06 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> src/hotspot/cpu/s390/assembler_s390.inline.hpp line 52:
>> 
>>> 50:         *(unsigned short*)(pos)   = (unsigned short)(x>>16);
>>> 51:         *(unsigned short*)(pos+2) = (unsigned short)x;
>>> 52:       }
>> 
>> Looks correct, but what is the motivation behind splitting unaligned stores? z can store to unaligned memory.
>
> Will go back to single int store for 4-byte instructions.

Ok. I'm fine with either version. Maybe the reason you did it this way was to be more consistent with the 6 Byte version.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7324


More information about the hotspot-compiler-dev mailing list