RFR: 8281079: [s390] Unify Address Operand Encoding in Instruction Emitters

Tue Feb 22 08:47:50 UTC 2022

On Tue, 22 Feb 2022 08:22:25 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Want some detailed comment here?
>
> I can understand it, but a short comment would be appreciated. E.g. length can only be >2 if first 2 bits are != 0.

Will rework with next commit.

>> You mean I should not explain what's going on?
>
> The explanation in the middle is fine. What's the value of the first and last sentence? The first one is already expressed by ShouldNotReachHere, the last one is a general statement which I don't like to be at every switch.

Will rework with next commit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7324