RFR: 8005885: enhance PrintCodeCache to print more data [v3]
Evgeny Astigeevich
duke at openjdk.java.net
Tue Feb 22 18:10:56 UTC 2022
On Tue, 22 Feb 2022 17:38:17 GMT, Yi-Fan Tsai <duke at openjdk.java.net> wrote:
>> 8005885: enhance PrintCodeCache to print more data
>
> Yi-Fan Tsai has updated the pull request incrementally with one additional commit since the last revision:
>
> Add back percentage and change descriptions
Changes requested by eastig at github.com (no known OpenJDK username).
src/hotspot/share/code/codeCache.cpp line 1484:
> 1482:
> 1483: tty->print_cr("nmethod dependency checking time %fs", dependentCheckTime.seconds());
> 1484: for (int i = 0; i <= CompLevel_full_optimization; i++) {
I suggest to add:
tty->print_cr("Nmethod blobs per compilation level:");
before the loop.
src/hotspot/share/code/codeCache.cpp line 1492:
> 1490: case CompLevel_full_profile: level_name = "CompLevel_full_profile"; break;
> 1491: case CompLevel_full_optimization: level_name = "CompLevel_full_optimization"; break;
> 1492: default: assert(false, "invalid compLevel");
Could you please put 'level_name = ; break;' into separate lines? It should improve readability .
-------------
PR: https://git.openjdk.java.net/jdk/pull/7389
More information about the hotspot-compiler-dev
mailing list