RFR: 8282172: CompileBroker::log_metaspace_failure is called from non-Java/compiler threads [v2]

Aleksey Shipilev shade at openjdk.java.net
Wed Feb 23 17:08:33 UTC 2022


On Wed, 23 Feb 2022 16:55:26 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Another fix
>>  - Merge branch 'master' into JDK-8282172-compiler-broker-message
>>  - Fix
>
> src/hotspot/share/compiler/compileBroker.cpp line 2038:
> 
>> 2036:   const char* message = "some methods may not be compiled because metaspace "
>> 2037:                         "is out of memory";
>> 2038:   if (_compilation_log != NULL) {
> 
> Okay. But  can you add the thread check here so that at least we get message with `PrintCompilation`?

Nevermind, let's do it your way. The over-logging is better than under-logging. See new commit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7555


More information about the hotspot-compiler-dev mailing list