RFR: 8005885: enhance PrintCodeCache to print more data [v5]

Evgeny Astigeevich duke at openjdk.java.net
Thu Feb 24 15:45:08 UTC 2022


On Thu, 24 Feb 2022 00:42:59 GMT, Yi-Fan Tsai <duke at openjdk.java.net> wrote:

>> 8005885: enhance PrintCodeCache to print more data
>
> Yi-Fan Tsai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add a test on code cache verbose output

Two minor comments.

test/hotspot/jtreg/compiler/codecache/CheckCodeCacheInfo.java line 2:

> 1: /*
> 2:  * Copyright (c) 2022, Amazon.com Inc. or its affiliates. All rights reserved.

We don't specify a year any more.
The correct one is "Copyright Amazon.com Inc. or its affiliates. All Rights Reserved." See https://github.com/openjdk/jdk/pull/6915

test/hotspot/jtreg/compiler/codecache/CheckCodeCacheInfo.java line 26:

> 24: /*
> 25:  * @test CheckCodeCacheInfo
> 26:  * @summary Checks VM verbose information related to the code cache

Missing `@bug 8005885`

-------------

Changes requested by eastig at github.com (no known OpenJDK username).

PR: https://git.openjdk.java.net/jdk/pull/7389


More information about the hotspot-compiler-dev mailing list