RFR: 8278784: C2: Refactor PhaseIdealLoop::remix_address_expressions() so it operates on longs [v2]

Wed Jan 5 11:51:57 UTC 2022

On Tue, 4 Jan 2022 14:25:57 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> Otherwise, the refactoring looks good! The comments are mostly about code style and further refactoring suggestions of touched existing code. Nice IR tests!

Thanks for the review. I pushed a new commit that should take all your comments/suggestions into account.

> src/hotspot/share/opto/loopopts.cpp line 408:
> 
>> 406:       add_var = add->in(2);
>> 407:       Node *add_var_ctrl = get_ctrl(add_var);
>> 408:       IdealLoopTree *add_var_loop = get_loop(add_var_ctrl);
> 
> The variable is unused. Is `get_loop()` just meant as sanity check? I first thought it accidentally shadows the previous variable definition on L396 instead of updating the variable but it is unused afterwards.

Right, it has to be dead code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6892