RFR: 8279282: [vectorapi] Matcher::supports_vector_comparison_unsigned is not needed on x86 [v2]

[Paul Sandoz]

On Thu, 6 Jan 2022 03:51:21 GMT, Quan Anh Mai <duke at openjdk.java.net> wrote:

>> src/hotspot/cpu/x86/x86.ad line 7332:
>> 
>>> 7330:             Matcher::vector_length_in_bytes(n->in(1)->in(1)) <= 32 && // src1
>>> 7331:             is_integral_type(Matcher::vector_element_basic_type(n->in(1)->in(1))) &&
>>> 7332:             (n->in(2)->get_int() == BoolTest::eq ||
>> 
>> It's tempting to add a method to check the third bit of a `BoolTest` value, which controls the sense of the result e.g. `eq(0)` and `ne(4)`, rather than three separate checks e.g. `is_negated` perhaps. That it turn may result in more clearer naming of the methods rather than using `_pri` and `_sec`, and the logic percolates down into `vpcmpCCW` via the `ComparisonPredicate` value and the use of the tmp register.
>
> Thanks a lot for the suggestion. The situation is quite unique in this case and I can't find anywhere else the need for the check of the third bit. So I just renamed the nodes here to be more descriptive. What do you think?

That's reasonable.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6966