RFR: 8274243: Implement fast-path for ASCII-compatible CharsetEncoders on aarch64 [v2]
Patric Hedlin
phedlin at openjdk.java.net
Mon Jan 10 14:05:23 UTC 2022
On Wed, 5 Jan 2022 18:21:00 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> With the limited use and scope, I see no need to.
>
> That's unfortunate.
> As a general rule, it's good to err on the side of robustness, if only fo the sake of solid code and defence in depth. Especially where, as here, the compile-time cost is nearly zero, and the runtime cost exactly zero. I presume you're thinking about some kind of cost/benefit balance, but I am at a loss to understand what the downside of following the common pattern may be.
Since you insist, please correct your suggested change to be committed (through the review interface).
-------------
PR: https://git.openjdk.java.net/jdk/pull/6945
More information about the hotspot-compiler-dev
mailing list