RFR: 8278302: [s390] Implement fast-path for ASCII-compatible CharsetEncoders

Lutz Schmidt lucy at openjdk.java.net
Mon Jan 10 22:24:27 UTC 2022


On Mon, 10 Jan 2022 19:59:29 GMT, Tyler Steele <duke at openjdk.java.net> wrote:

>> Had already contacted Tim Ellison (RedHat) before Christmas. He promised to point an engineer to this PR.
>
> @RealLucy, sorry to keep you waiting. I am currently running tier1-tests on our s390x system. I'll edit this comment with the results when it completes.
> 
> ---
> 
> I'll have to rebuild with gtest to get complete results. For now, I see the following failure, though I'm not sure if it relates to your changes.
> 
> 
> ----------System.out:(5/185)----------
> CompileCommand: dontinline compiler/unsafe/UnsafeCopyMemory.test* bool dontinline = true
> INTERPRETED
> testHeapToHeap: 1 4
> testHeapToHeapMixed: 1 4
> testHeapToHeapMismatched: 4294967298 4
> ----------System.err:(16/995)----------
> java.lang.RuntimeException: assertEquals: expected 4294967298 to equal 1
> 	at jdk.test.lib.Asserts.fail(Asserts.java:594)
> 	at jdk.test.lib.Asserts.assertEquals(Asserts.java:205)
> 	at jdk.test.lib.Asserts.assertEquals(Asserts.java:189)
> 	at jdk.test.lib.Asserts.assertEQ(Asserts.java:166)
> 	at compiler.unsafe.UnsafeCopyMemory.runTests(UnsafeCopyMemory.java:340)
> 	at compiler.unsafe.UnsafeCopyMemory.main(UnsafeCopyMemory.java:437)
> 	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
> 	at java.base/java.lang.reflect.Method.invoke(Method.java:577)
> 	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> 	at java.base/java.lang.Thread.run(Thread.java:833)

@backwaterred Thanks for working on the tests.
At first glance, the failure you are seeing doesn't immediately suggest it's my changes that are causing it. Do I understand the text "INTERPRETED" correctly if I assume the test was running without JIT compilation?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6738


More information about the hotspot-compiler-dev mailing list