RFR: 8274243: Implement fast-path for ASCII-compatible CharsetEncoders on aarch64 [v3]
Patric Hedlin
phedlin at openjdk.java.net
Tue Jan 11 09:04:12 UTC 2022
> Implementation of ISO/ASCII char set encoding, extending current implementation with ASCII encoding support.
>
> The motivation is found in the original x86 issue ([JDK-8274242](https://bugs.openjdk.java.net/browse/JDK-8274242)).
>
> Implementation with some focus on balance between footprint and efficiency, trying to utilise a dual SIMD path (e.g. Neoverse N1) for the additional ASCII-check and avoid performance loss in the ISO-only case.
>
> - Interleaved ISO and ASCII check code.
> - Avoid 'umaxv' in the ISO main flow.
> - Using post inc in main loop.
> - Retain 8-char loop.
> - Removing conditional prefetch (no upside).
> - Adding ISO-8859-1 to encode-decode benchmark.
>
> Testing (Linux): tier1-6
>
> The revised version compares like this (master vs. update).
>
> Benchmark (size) (type) Mode Cnt Score Error Units
> CharsetEncodeDecode.encode 16384 UTF-8 avgt 30 17.920 ± 0.229 us/op
> CharsetEncodeDecode.encode 16384 BIG5 avgt 30 18.867 ± 0.356 us/op
> CharsetEncodeDecode.encode 16384 ISO-8859-15 avgt 30 17.419 ± 0.220 us/op
> CharsetEncodeDecode.encode 16384 ISO-8859-1 avgt 30 6.200 ± 0.134 us/op
> CharsetEncodeDecode.encode 16384 ASCII avgt 30 17.149 ± 0.219 us/op
> CharsetEncodeDecode.encode 16384 UTF-16 avgt 30 135.115 ± 1.440 us/op
>
>
> Benchmark (size) (type) Mode Cnt Score Error Units
> CharsetEncodeDecode.encode 16384 UTF-8 avgt 30 9.018 ± 0.179 us/op
> CharsetEncodeDecode.encode 16384 BIG5 avgt 30 10.550 ± 0.470 us/op
> CharsetEncodeDecode.encode 16384 ISO-8859-15 avgt 30 8.843 ± 0.187 us/op
> CharsetEncodeDecode.encode 16384 ISO-8859-1 avgt 30 6.406 ± 0.155 us/op
> CharsetEncodeDecode.encode 16384 ASCII avgt 30 8.822 ± 0.173 us/op
> CharsetEncodeDecode.encode 16384 UTF-16 avgt 30 135.195 ± 1.432 us/op
Patric Hedlin has updated the pull request incrementally with one additional commit since the last revision:
Update src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp
Co-authored-by: Andrew Haley <aph-open at littlepinkcloud.com>
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/6945/files
- new: https://git.openjdk.java.net/jdk/pull/6945/files/59dca321..ba6c73ff
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6945&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6945&range=01-02
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/6945.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/6945/head:pull/6945
PR: https://git.openjdk.java.net/jdk/pull/6945
More information about the hotspot-compiler-dev
mailing list