Integrated: JDK-8258603 c1 IR::verify is expensive

[Ludvig Janiuk]

On Wed, 15 Dec 2021 15:39:26 GMT, Ludvig Janiuk <duke at openjdk.java.net> wrote:

> IR::verify iterates the whole object graph. This proves costly when used in e.g. BlockMerger inside of iterations over BlockLists, leading to quadratic or worse complexities as a function of bytecode length. In several cases, only a few Blocks were changed, and there was no need to go over the whole graph, but until now there was no less blunt tool for verification than IR::verify.
> 
> This PR introduces IR::verify_local, intended to be used when only a defined set of blocks have been modified. As a complement, expand_with_neighbors provides a way to also capture the neighbors of the "modified set" ahead of modification, so that afterwards the appropriate asserts can be made on all blocks which might possibly have been changed. All this should let us remove the expensive IR::verify calls, while still performing equivalent (or stricter) assertions.
> 
> Some changes have been made in the verifiers along the way. Some amount of refactoring, and even added invariants (see validate_edge_mutiality).

This pull request has now been integrated.

Changeset: d70545d7
Author:    Ludvig Janiuk <ludvig.j.janiuk at oracle.com>
Committer: Vladimir Kozlov <kvn at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/d70545d71080d534fefd3c9652656549f689f620
Stats:     158 lines in 4 files changed: 123 ins; 13 del; 22 mod

8258603: c1 IR::verify is expensive

Reviewed-by: chagedorn, kvn

-------------

PR: https://git.openjdk.java.net/jdk/pull/6850