RFR: 8279947: Remove two redundant gvn.transform calls in Parse::do_one_bytecode()

Jie Fu jiefu at openjdk.java.net
Thu Jan 13 06:37:25 UTC 2022


On Thu, 13 Jan 2022 03:47:37 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Hi all,
> 
> May I get reviews for this small change?
> 
> The patch removes two `gvn.transform` calls in `Parse::do_one_bytecode()` which I think they are redundant.
> Or am I missing something?
> 
> Testing:
>   - tier1~3 on Linux/x64, no regression
> 
> Thanks.
> Best regards,
> Jie

jdk/javadoc/doclet/testLinkPlatform/TestLinkPlatform.java failed on Linux/x86_32.

2022-01-13T04:57:07.2128151Z #
2022-01-13T04:57:07.2128387Z # A fatal error has been detected by the Java Runtime Environment:
2022-01-13T04:57:07.2128625Z #
2022-01-13T04:57:07.2128862Z #  Internal Error (g1ConcurrentMark.cpp:1649), pid=29309, tid=29318
2022-01-13T04:57:07.2129283Z #  fatal error: Overflow during reference processing, can not continue. Please increase MarkStackSizeMax (current value: 4194304) and restart.
2022-01-13T04:57:07.2129602Z #
2022-01-13T04:57:07.2130072Z # JRE version: OpenJDK Runtime Environment (19.0) (build 19-internal+0-DamonFool-79c0e965d441401e18a6aa3e3324667e1f73cf90)
2022-01-13T04:57:07.2130816Z # Java VM: OpenJDK Server VM (19-internal+0-DamonFool-79c0e965d441401e18a6aa3e3324667e1f73cf90, mixed mode, tiered, g1 gc, linux-x86)
2022-01-13T04:57:07.2131186Z # Problematic frame:
2022-01-13T04:57:07.2146340Z # V  [libjvm.so+0x570860]  G1ConcurrentMark::weak_refs_work()+0x320
2022-01-13T04:57:07.2146611Z #
2022-01-13T04:57:07.2146846Z # CreateCoredumpOnCrash turned off, no core file dumped
2022-01-13T04:57:07.2147085Z #
2022-01-13T04:57:07.2147441Z # An error report file with more information is saved as:
2022-01-13T04:57:07.2148041Z # /home/runner/work/jdk/jdk/build/run-test-prebuilt/test-support/jtreg_test_langtools_tier1/scratch/hs_err_pid29309.log


However, I don't think it was caused by my change since it's a gc failure instead of a compiler bug and it passed in my local test.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7059


More information about the hotspot-compiler-dev mailing list