RFR: 8279570: IGV: Add source/destination property for load and store nodes with an associated field [v2]

Christian Hagedorn chagedorn at openjdk.java.net
Thu Jan 13 08:36:59 UTC 2022


On Thu, 13 Jan 2022 07:45:01 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change to Node::uncast
>
> src/hotspot/share/opto/idealGraphPrinter.cpp line 710:
> 
>> 708:     if (base != NULL) {
>> 709:       if (base->Opcode() == Op_CastPP) {
>> 710:         // CastPP node could have been removed.
> 
> There could also be a `CheckCastPP` or multiple casts, right? I would suggest to use `Node::uncast`.

Good point! I've updated it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7048


More information about the hotspot-compiler-dev mailing list