RFR: 8276673: Optimize abs operations in C2 compiler [v6]

Fei Gao fgao at openjdk.java.net
Fri Jan 14 06:46:27 UTC 2022


On Mon, 10 Jan 2022 12:12:59 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Fei Gao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use uabs() to calculate the absolute value of constant
>>   
>>   Change-Id: Ie6f37ab159fb7092e1443b9af8d620562a45ae47
>
> src/hotspot/share/opto/subnode.cpp line 1897:
> 
>> 1895:     PhaseIterGVN* igvn = phase->is_IterGVN();
>> 1896:     if (igvn) {
>> 1897:       igvn->_worklist.push(in1);
> 
> Why is that needed? Because `in1` could become dead? You should use `set_req_X` above.

Done. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6755


More information about the hotspot-compiler-dev mailing list