RFR: 8280003: C1: Reconsider uses of logical_and immediates in LIRGenerator::do_getObjectSize

Sergey Nazarkin snazarki at openjdk.java.net
Fri Jan 14 13:34:35 UTC 2022


On Fri, 14 Jan 2022 11:05:45 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> See the discussion in the bug.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug `java/lang/instrument`
>  - [x] Linux x86_32 fastdebug `java/lang/instrument`
>  - [x] Linux AArch64 fastdebug `java/lang/instrument`
>  - [x] Linux PPC64 fastdebug `java/lang/instrument`
>  - [x] Linux x86_64 fastdebug `tier1`
>  - [x] Linux x86_32 fastdebug `tier1`
>  - [x] Linux AArch64 fastdebug `tier1`
>  - [x] Linux PPC64 fastdebug `tier1`

src/hotspot/cpu/arm/c1_LIRGenerator_arm.cpp line 291:

> 289:   assert(type == T_LONG || type == T_INT, "should be");
> 290:   LIR_Opr r = make_constant(type, x);
> 291:   bool imm_in_range = AsmOperand::is_rotated_imm(x);

is_rotated_imm accepts unsigned int and may return false positive

-------------

PR: https://git.openjdk.java.net/jdk/pull/7080


More information about the hotspot-compiler-dev mailing list