RFR: 8280026: Cleanup of IGV printing

[Christian Hagedorn]

On Fri, 14 Jan 2022 15:15:30 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

> This is a clean up of the code that controls the printing of IGV graphs. This is preparatory work for another patch.
> 
> * Default params removed when they are only used in the non-default case.
> * Moved code around so that methods with similar concern are kept together
> * Move some code from hpp to cpp file
> * Changed name of print_method with actual implementation to print_method_impl to clarify intent
> * Removed the print_method that was used with a node idx. I once introduced it for debugging - but now there are also other versions that pass a node.
> 
> Please revew,
> Nils

Otherwise, looks good!

src/hotspot/share/opto/compile.cpp line 4823:

> 4821: 
> 4822:   bool need = directive()->IGVPrintLevelOption >= level;
> 4823:   if (need && !_printer) {

Could be changed into `_printer == NULL`.

-------------

Marked as reviewed by chagedorn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7088