RFR: 8280003: C1: Reconsider uses of logical_and immediates in LIRGenerator::do_getObjectSize [v2]
Aleksey Shipilev
shade at openjdk.java.net
Tue Jan 18 06:51:27 UTC 2022
On Mon, 17 Jan 2022 19:52:10 GMT, Sergey Nazarkin <snazarki at openjdk.org> wrote:
>> Right. The best I can come up with is to check the `x` fits the unsigned int. See new commit. I know it builds (cross-compiles), but not sure if it passes tests.
>
> I still observe test failure. Have you tested on x86_32?
> `----------System.err:(15/1051)----------
> java.lang.IllegalStateException: Error: expected: 1040 (410), actual: 192 (c0)
> at GetObjectSizeIntrinsicsTest.assertEquals(GetObjectSizeIntrinsicsTest.java:294)
> at GetObjectSizeIntrinsicsTest.testSize_newSmallByteArray(GetObjectSizeIntrinsicsTest.java:357)`
Yes, I did test on x86_32, see the "Additional testing" in the PR body. I just re-ran the tests on x86_32, they pass. Are you seeing this failure on ARM32?
-------------
PR: https://git.openjdk.java.net/jdk/pull/7080
More information about the hotspot-compiler-dev
mailing list