RFR: 8280026: Cleanup of IGV printing [v2]

Tobias Hartmann thartmann at openjdk.java.net
Tue Jan 18 07:33:21 UTC 2022


On Mon, 17 Jan 2022 15:22:56 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

>> This is a clean up of the code that controls the printing of IGV graphs. This is preparatory work for another patch.
>> 
>> * Default params removed when they are only used in the non-default case.
>> * Moved code around so that methods with similar concern are kept together
>> * Move some code from hpp to cpp file
>> * Changed name of print_method with actual implementation to print_method_impl to clarify intent
>> * Removed the print_method that was used with a node idx. I once introduced it for debugging - but now there are also other versions that pass a node.
>> 
>> Please revew,
>> Nils
>
> Nils Eliasson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Feedback

Looks good.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7088


More information about the hotspot-compiler-dev mailing list