RFR: 8280089: compiler/c2/irTests/TestIRAbs.java fails on some arches [v2]

[Tobias Hartmann]

On Tue, 18 Jan 2022 08:11:03 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> This new test is apparently fails in GHA. 
>> 
>> The trouble is that AbsL parts of the test are arch-specific, as only {x86_64,aarch64,ppc64,s390}.ad have the match rules for AbsL. x86_32.ad does not have it, so C2 never actually emits AbsL in x86_32 case. AbsI, AbsF, AbsD are also not supported by arm.ad.
>> 
>> I wonder if IR Test Framework might be able to disable subtests based on arch... It is probably all around easier to make this test x86_64 specific. It tests shared C2 code, so testing one architecture is probably enough. 
>> 
>> Open for other suggestions, though.
>> 
>> Additional testing:
>>  - [x] Linux x86_64 fastdebug, test still passes
>>  - [x] Linux x86_32 fastdebug, test used to fail, now is skipped
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add AArch64 too

That looks good and trivial to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7116