RFR: 8280076: Unify IGV and IR printing [v2]

Nils Eliasson neliasso at openjdk.java.net
Tue Jan 18 08:30:28 UTC 2022


On Mon, 17 Jan 2022 13:53:39 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Nils Eliasson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.
>
> src/hotspot/share/opto/compile.cpp line 539:
> 
>> 537: 
>> 538: #ifndef PRODUCT
>> 539: void Compile::print_ideal_ir(const char *name) {
> 
> I suggest to call it `compile_phase` instead of `name`. 
> Also: `const char *name` - > `const char* name`.

I also removed default value in hpp declaration.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7108


More information about the hotspot-compiler-dev mailing list