[jdk18] RFR: 8272058: 25 Null pointer dereference defect groups in 4 files [v5]

Daniel D.Daugherty dcubed at openjdk.java.net
Wed Jan 19 17:25:19 UTC 2022


> A small refactoring to resolve a Parfait complaint about the return value from
> `MacroAssembler::target_addr_for_insn(address insn_addr, unsigned insn)`
> on AARCH64. The logic that supports returning `nullptr` as the target addr for
> a particular instruction is moved from
> `MacroAssembler::target_addr_for_insn(address insn_addr, unsigned insn)` to
> `MacroAssembler::target_addr_for_insn_allow_null_ret(address insn_addr, unsigned insn)`.
> A couple of `target_addr_for_insn()` call sites that can tolerate a `nullptr` are
> converted to use `target_addr_for_insn_allow_null_ret()`.
> 
> This fix has been tested with Mach5 Tier[1-3].

Daniel D. Daugherty has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:

 - Rename target_addr_for_insn_allow_null_ret to target_addr_for_insn_or_null.
 - Merge branch 'master' into JDK-8272058
 - copyright updates for 2022.
 - Merge branch 'master' into JDK-8272058
 - bulasevich CR - use NativeInstruction::is_ldrw_to_zr() instead of raw constants.
 - Merge branch 'master' into JDK-8272058
 - 8272058.exp1.patch

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk18/pull/51/files
  - new: https://git.openjdk.java.net/jdk18/pull/51/files/0c23024f..3cd45516

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk18&pr=51&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk18&pr=51&range=03-04

  Stats: 2000 lines in 74 files changed: 1174 ins; 591 del; 235 mod
  Patch: https://git.openjdk.java.net/jdk18/pull/51.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/51/head:pull/51

PR: https://git.openjdk.java.net/jdk18/pull/51


More information about the hotspot-compiler-dev mailing list