RFR: 8280457: Duplicate implementaion of dprecision_rounding and dstore_rounding

Vladimir Ivanov vlivanov at openjdk.java.net
Fri Jan 21 16:55:42 UTC 2022


On Fri, 21 Jan 2022 15:16:49 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Hi all,
>> 
>> `GraphKit::dprecision_rounding` and `GraphKit::dstore_rounding` are duplicate.
>> It would be better to remove one of them.
>> 
>> The patch removes `GraphKit::dstore_rounding` and replaces all the usages with `GraphKit::dprecision_rounding`.
>> 
>> Thanks.
>> Best regards,
>> Jie
>
> src/hotspot/share/opto/graphKit.cpp line 2355:
> 
>> 2353:         // the call, precision_rounding does gvn.transform
>> 2354:         Node *arg = argument(j);
>> 2355:         arg = precision_rounding(arg);
> 
> Hold on. This should be `dprecision_rounding`, with a `d`?

Good catch!

-------------

PR: https://git.openjdk.java.net/jdk/pull/7176


More information about the hotspot-compiler-dev mailing list