RFR: 8280457: Duplicate implementation of dprecision_rounding and dstore_rounding [v2]

David Holmes dholmes at openjdk.java.net
Mon Jan 24 02:26:07 UTC 2022


On Fri, 21 Jan 2022 23:29:54 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Hi all,
>> 
>> `GraphKit::dprecision_rounding` and `GraphKit::dstore_rounding` are duplicate.
>> It would be better to remove one of them.
>> 
>> The patch removes `GraphKit::dstore_rounding` and replaces all the usages with `GraphKit::dprecision_rounding`.
>> 
>> Thanks.
>> Best regards,
>> Jie
>
> Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   precision_rounding --> dprecision_rounding

src/hotspot/share/opto/graphKit.hpp line 790:

> 788:   Node* precision_rounding(Node* n);
> 789: 
> 790:   // rounding for strict double precision conformance

Isn't the reference to "strict" here and in the cpp file no longer applicable?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7176


More information about the hotspot-compiler-dev mailing list