Integrated: JDK-8280274: Guard printing code of Compile::print_method in PRODUCT

Tobias Holenstein duke at openjdk.java.net
Tue Jan 25 10:03:42 UTC 2022


On Thu, 20 Jan 2022 13:30:05 GMT, Tobias Holenstein <duke at openjdk.java.net> wrote:

> In `Compile::print_method(CompilerPhaseType cpt, Node* n, int level)` the code 
> ``` 
> ResourceMark rm; 
> stringStream ss; 
> ss.print_raw(CompilerPhaseTypeHelper::to_string(cpt)); 
> if (n != NULL) { 
>   ss.print(": %d %s ", n->_idx, NodeClassNames[n->Opcode()]); 
> } else { 
>   ss.print_raw(": NULL"); 
> } 
> ``` 
> should to be guarded by a `#ifndef PRODUCT` since the usage of the string is also guarded in `Compile::print_method_impl`
> 
> Tested on Tier1-3

This pull request has now been integrated.

Changeset: 1b141576
Author:    Tobias Holenstein <71546117+tobiasholenstein at users.noreply.github.com>
Committer: Tobias Hartmann <thartmann at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/1b14157677b34891385f643a76a7aa19d7003acf
Stats:     8 lines in 2 files changed: 2 ins; 0 del; 6 mod

8280274: Guard printing code of Compile::print_method in PRODUCT

Reviewed-by: thartmann, neliasso

-------------

PR: https://git.openjdk.java.net/jdk/pull/7158


More information about the hotspot-compiler-dev mailing list