RFR: 8280686: Remove Compile::print_method_impl

[Christian Hagedorn]

On Wed, 26 Jan 2022 07:41:18 GMT, Xin Liu <xliu at openjdk.org> wrote:

> This is a follow-up task of JDK-8280274. I think it is still reasonable to only evaluate
> "CompilerPhaseTypeHelper::to_string(cpt)" when NOT_PRODUCT is defined, but we can do
> that in the function body. We should avoid from messing around interfaces with macros.
> 
> Actually, it's not necessary to have print_method_impl as a public interface at all.
> The only client of it is print_method().
> 
> Here is the current interface of Compile::print_method
> V1: print_method(CompilerPhaseType cpt, int level)
> V2: print_method(CompilerPhaseType cpt, Node* n, int level)
> 
> The only client of V2 is vector.cpp. It attempts to dump the phase name and vec_box node. It's impossible to to have n=NULL. No one will consume property <"phase :NULL">.
> 
> I think we should go in this way.
> 
> void Compile::print_method(CompilerPhaseType cpt, int level) {
>   print_method(cpt, NULL, level);
>   }
> 
> 
> Testing: 
> Verify that igv is still working with PrintIdealGraphLevel=3/4

src/hotspot/share/opto/compile.cpp line 4821:

> 4819: }
> 4820: 
> 4821: void Compile::print_method(CompilerPhaseType cpt, Node* n, int level) {

Could we also turn `Node* n` into a parameter with default argument `NULL`? Then we can merge both `print_method` methods into one.

src/hotspot/share/opto/compile.cpp line 4834:

> 4832:   }
> 4833: 
> 4834:   const char *name = ss.as_string();

Nit: `*` position:
Suggestion:

  const char* name = ss.as_string();

-------------

PR: https://git.openjdk.java.net/jdk/pull/7229